Update macros.nim #747
Closed
Update macros.nim #747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newProc() makes more sense, use returnType parameter instead of requiring it be in the params parameter
|
This change will break any code that uses newProc already, perhaps you should deprecate |
|
dom96 is right. |
|
Cannot do that, with all the default arguments, overloading is impossible |
Clyybber
pushed a commit
to Clyybber/Nim
that referenced
this pull request
Sep 16, 2023
## Summary When using `--gc:orc`, run a full cycle collection pass prior to exiting the internal thread procedure, freeing all heap cells only kept alive through reference cycles created by the thread. Previously, they were simply not freed, with manually freeing them being impossible once the thread terminated. ## Details Running the cycle collector (via ``GC_fullCollect``) has to happen *before* deallocating the ``GcThread`` instance, as the latter step frees - when using emulated thread-local storage - the thread's thread-local storage (which the cycle collector still depends on).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
newProc() makes more sense, use returnType parameter instead of requiring it be in the params parameter