Added count(*) support to sql parser. Fixed warnings in sql parser. #7490
Conversation
lib/pure/parsesql.nim
Outdated
| proc repr*(node: SqlNode): string = | ||
| result = $node.kind | ||
| if node.kind in LiteralNodes: | ||
| result &= " \"" & node.strVal & "\"" |
There was a problem hiding this comment.
I don't like how this repr works anyways. I'll just remove the whole function for now.
lib/pure/parsesql.nim
Outdated
| for i, son in node.sons: | ||
| if i > 0: | ||
| result &= ", " | ||
| result &= repr(son) |
There was a problem hiding this comment.
That is expensive, change repr to take result: var string parameter.
There was a problem hiding this comment.
You are right its not ideal. Do other reprs take result: var string?
There was a problem hiding this comment.
No, usually the $ operator is overloaded and it uses a helper proc that uses the var string in the recursions. In fact, overloading of repr is simply not done in the stdlib (except for macros.nim and it's a mistake there too).
|
I have another problem related to this code I don't know how to fix. I want to use this code in JavaScript (client side SQL validation) but it uses |
Yeah, go for it. I'll help you out on IRC. |
|
How I solved this in the |
lib/pure/parsesql.nim
Outdated
| result = newNode(nkIdent, p.tok.literal) | ||
| getTok(p) | ||
| of tkIdentifier: | ||
| if p.tok.literal.toLowerAscii() in SqlFunctions: |
There was a problem hiding this comment.
Er, that is not how the SQL is supposed to work. We don't know the SQL functions there can be hundreds per SQL dialect. Why special case these few? It also makes the parser slower, tkIdentifier is likely on the critical path.
There was a problem hiding this comment.
I removed the functions list, but I had to pass Quoted Identifiers from tokens to nodes as there needs to be a way to say quote foo as "count" and also have the unquoted count(*).
lib/pure/parsesql.nim
Outdated
| nkPrefix, | ||
| nkInfix, | ||
| nkCall, | ||
| nkFunction, |
treeform
force-pushed
the
sqlfix2
branch
2 times, most recently
from
238500f to
70a7161
Compare
|
@dom96 It looks like you just use the native json parser for javascript and then build nim nodes out out it's output? |
nkQuotedIdentnode type.toUpperAsciiandtoLowerAscii.