Jump to conversation
Unresolved conversations (2)
@Araq Araq Apr 14, 2018
I'm sure you find some Context object where this can be put into. Globals make the compiler hard to use as a library.
compiler/jsgen.nim
alehander92
@Araq Araq Apr 14, 2018
I know it says "optimize me" but this tokenizer is really easy enough to make lazy. The compiler's lexer module shows how a lexer can be written.
Outdated
compiler/sourcemap.nim
alehander92
Resolved conversations (5)
@Araq Araq Apr 14, 2018
Why would I need to check for that in a ``when compileOption``? Remove this line please.
Outdated
compiler/commands.nim
alehander92
@Araq Araq Apr 14, 2018
I think ``optSourceMap`` should be a global option instead.
Outdated
compiler/options.nim
alehander92
@Araq Araq Apr 14, 2018
Doesn't this prove you wrong? People do use '//' in emits influencing your parser.
Outdated
lib/system/jssys.nim
Araq alehander92
@Araq Araq Apr 14, 2018
This is a bit ridiculous. You want a ``pure`` enum and then a short notation? So use instead ```nim type C* = enum cSourceNode, cString ```
Outdated
compiler/sourcemap.nim
alehander92
@Araq Araq Apr 14, 2018
No, clients use ``rope(s)``.
Outdated
compiler/ropes.nim