Expand gitignore to include all binaries built by ./koch test. #752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whoever feels imperiously: is it going to be merged? If not, please close this issue, so it won't clobber list. (And mind that this option is better than others in at least one way: it's already ready). |
gradha
added a commit
that referenced
this pull request
Dec 17, 2013
Expand gitignore to include all binaries built by ./koch test.
reactormonk
pushed a commit
to reactormonk/nim
that referenced
this pull request
Apr 7, 2014
Expand gitignore to include all binaries built by ./koch test.
Clyybber
pushed a commit
to Clyybber/Nim
that referenced
this pull request
Sep 16, 2023
## Summary Unmarshaling a `Table` or `OrderedTable` where the key is a `cstring` via `fromJsonHook` cannot be implemented to work in a safe way, at least when using the C backend. For this reason, the overload is removed. ## Details The reason that it cannot work for the C target, is that `cstring`s are unsafe views into strings there, so the keys of the table can, in theory, only be valid for as long as the source `JsonNode` is alive (and unchanged). In practice, due to the iterators used by `fromJsonHook` not using `lent` and thus introducing temporary copies, the `cstring` keys were only valid for the loop iteration in which they were added to the table. The test case that existed for `OrderedTable[cstring, int]` only worked by accident. Changing the allocation behaviour, building with `-d:useMalloc`, or enabling memory sanitizers would all result in test failures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated using "git status --porcelain" on Linux - all these files are executables.