Skip to content

Move timers module to lib/pure (WIP) #7560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Move timers module to lib/pure (WIP) #7560

wants to merge 4 commits into from

Conversation

data-man
Copy link
Contributor

No description provided.

@GULPF
Copy link
Member

GULPF commented Apr 10, 2018

What's the purpose of the timers module? It looks like it's meant for measuring intervals using monotonic time, but on posix it uses non-monotonic time (neither CLOCK_REALTIME or posix_gettimeofday are monotonic). I think it's a better idea to add a monotonic time type to the times module after #6978 has been merged (so that the Duration type can be used), similiar to D's MonoTime.

@data-man
Copy link
Contributor Author

@GULPF
Therefore WIP

@timotheecour
Copy link
Member

ping: #6978 was finally merged

@dom96
Copy link
Contributor

dom96 commented Apr 17, 2018

We should name this module something else IMO. The name is too similar to times.

@dom96
Copy link
Contributor

dom96 commented Apr 17, 2018 •
edited
Loading

But actually, I agree with @GULPF. It's better to have this functionality in the times module.

@Araq
Copy link
Member

Araq commented Apr 21, 2018

Ok, let's not do this then, sorry @data-man

@Araq Araq closed this Apr 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@data-man @GULPF @timotheecour @dom96 @Araq