Async and CFRunLoop are friends now

[yglukhov]

This pr allows using asyndispatch in any thread of a conventional MacOS/iOS app, including the main thread.
Notes:

• Upon newDispatcher creation it's kqueue is added to current CFRunLoop. This only happens if the program was linked with CoreFoundation in the first place.
• Any event in this kqueue will trigger poll(0) to dispatch them.
• There's no performance hit for existing code using asyncdispatch.
• sleepAsync is not supported properly yet and may be laggy when CFRunLoop is used.

In future I'm planning to do the same for Android.

[euantorano]

Slight spelling change:

and relies on poll function

[dom96]

What's the rationale for putting this in the stdlib?

[yglukhov]

@dom96, the rationale is seamless macos support out of the box? I could start with a separate lib for now (given that we still expose some currently private fields), but that would still have implications that the user has to manually call some initializer code on every thread he wants to mix async and CFRunloop.

But isn't "seamless" macos support a good enough argument already? Or is there anything that bothers you about the impl?

[Araq]

I think it's cool.

[dom96]

What bothers me is that it's another bit of code that needs to be maintained and that I need to worry about as a potential cause of async issues. Nothing in the stdlib depends on it, so I don't see why it should be included. Sorry, but I think it can just as easily be a Nimble package.

[Araq]

How about we accept the changes that export the fields that make a nimble package easier to build against async?

[dom96]

A procedure to return the kqFd already exists. https://nim-lang.org/docs/asyncdispatch.html#getIoHandler,PDispatcher

…

On Tue, 17 Apr 2018, 00:26 Andreas Rumpf, ***@***.***> wrote: How about we accept the changes that export the fields that make a nimble package easier to build against async? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7571 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAPDe3jlQCZJirPVXTUtUmw7VFd9j-kfks5tpSiggaJpZM4TQGv_> .

[yglukhov]

Makes sense. Closing.