move eqIdent to vm.nim #7585
Merged
move eqIdent to vm.nim #7585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
well I did this for performance optimizatioon and now the build fails because build time exceeds the maximum allowed time. Well the question is, was this my fault, or was there heave work load on the server and the built failed because of that? |
Araq
reviewed
Apr 13, 2018
| decodeBC(rkInt) | ||
| if regs[rb].node.kind == nkIdent and regs[rc].node.kind == nkIdent: | ||
| regs[ra].intVal = ord(regs[rb].node.ident.id == regs[rc].node.ident.id) | ||
| # aliases for shorter and easier to understand code below |
There was a problem hiding this comment.
This is not bad, but since rawExecute is already really long (!), it should be extracted into a helper proc.
Araq
reviewed
Apr 13, 2018
lib/core/macros.nim
Outdated
| ## Style insensitive comparison. | ||
|
|
||
| proc eqIdent*(a: NimNode; b: string): bool {.magic: "EqIdent", noSideEffect.} | ||
| ## Style insesitive comparison. |
Araq
reviewed
Apr 13, 2018
lib/core/macros.nim
Outdated
| ## ``a`` can be an identifier or a symbol. | ||
|
|
||
| proc eqIdent*(a: string; b: NimNode): bool {.magic: "EqIdent", noSideEffect.} | ||
| ## Style insesitive comparison. |
Araq
reviewed
Apr 13, 2018
lib/core/macros.nim
Outdated
| ## ``b`` can be an identifier or a symbol. | ||
|
|
||
| proc eqIdent*(a: NimNode; b: NimNode): bool {.magic: "EqIdent", noSideEffect.} | ||
| ## Style insesitive comparison. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This actually adds a test for identifier equality. Then it almost removes one instance of the many duplicates of
cmpIgnoreStyle. Really copy pasting that function everywhere and then ensuring that the only central version in strutils.nim remains broken doesn't help at all.The main motivation for this change is that
eqIdentis called at lot in macros. I will also generate a lot of it form the ast pattern matching library that I am currently working on. I just wanted it to be fast.