rename SomeReal to SomeFloat #7617
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
SomeRealtypes were the superset of allFloattypes. That is not only inconsistent with the names, but it is also wrong. Here is a list of reasons why calling floating point numebrsreal(ℝ) is wrong.In words:
Or in other words, if you take all floating point numbers that are also real numbers, there is not a single value left, that would justify to call this number type "real numbers".
Thanks to deprecation mechanisms in Nim, this change doesn't break any code.