Skip to content

Better HTML links #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

Better HTML links #781

wants to merge 7 commits into from

Conversation

gradha
Copy link
Contributor

@gradha gradha commented Dec 27, 2013

@gradha
Adds title attribute to TOC links.
df37d01 
The title helps differentiating same name symbols in the TOC, especially
when they are heavily overloaded like in the system module.
@gradha
Removes the last pragma from proc like types.
1162466
@gradha
Adds plain symbol hrefs for human readable hyperlinks.
314235a
@gradha
Adds itemSymOrID for human readable toc hyperlinks.
3221862
@gradha
Makes symbol extraction not depend on visibility token.
cd32ea4 
The visibility token doesn't exist on doc2 phases, and therefore symbols
were being recorded as empty.
@gradha
Adds itemSymOrID for overloaded symbols.
cfbd805 
This is far from the ideal unique signature, but much better than a raw
numerical index.
@gradha
Adds quoted variables for valid URLs.
d7ebc0f
@gradha gradha closed this Dec 31, 2013
@gradha gradha deleted the pr_better_html_links branch December 31, 2013 18:51
Clyybber pushed a commit to Clyybber/Nim that referenced this pull request Sep 16, 2023
@saem
sem: typed AST normalizes out include stmts (nim-lang#781)
ddb38df 
## Summary

Previously `include` statements, outside of type sections, were re-added
to `typed` AST. This is no longer the case, they're instead wholy
replaced by the included AST, which prevents repeated processing and
is consistent with `include`'s behaviour in type sections.

## Details

`semstmts` evaluates both declarative and type sections includes. Only
declarative includes, handled in `evalInclude` reintroduced the
`nkIncludeStmt` node within its results. It's been modified to no longer
do that.

In addition, `evalInclude` used a one off procedure `incMod` as part of
its processing, this has been made an inner proc.

Also removed deadcode `semAllTypeSections` and the `rsemRecursiveImport`
legacy report.

Lastly, a test was added to ensure we don't regress.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gradha