Lexer fix for multi byte characters #7907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the comment means this line should be changed, too: Nim/lib/packages/docutils/highlite.nim Line 133 in 25a41d5 |
|
Fixed, thanks |
data-man
approved these changes
Jun 4, 2018
Araq
reviewed
Jun 4, 2018
tests/parser/tunicodeidents.nim
Outdated
| discard """ | ||
| action: run | ||
| """ | ||
|
|
There was a problem hiding this comment.
This test case can easily be added to one of the existing lexer tests instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that that multi byte characters where sometimes treated as operators.
Fixes #7884