Skip to content

Add the val parameter for CritBitTree[T].incl #7988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 8, 2018
Merged

Add the val parameter for CritBitTree[T].incl #7988

merged 3 commits into from
Jun 8, 2018

Conversation

data-man
Copy link
Contributor

@data-man data-man commented Jun 7, 2018

No description provided.

@Varriount
Copy link
Contributor

@data-man What about CritBit trees that have a void value?

@data-man
Copy link
Contributor Author

data-man commented Jun 8, 2018

@Varriount
There is proc incl(c: var CritBitTree[void]; key: string)
And proc `[]=`[T](c: var CritBitTree[T]; key: string; val: T)

I added it for compatibility with other collections.
It can be useful in macros/templates, for universal benchmark template, e.g.

@Varriount Varriount merged commit fbd91a4 into nim-lang:devel Jun 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@data-man @Varriount