Fixed crash when typedesc[T] was the first param of a proc. #849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This bug has been fixed in recent changes to the compiler. Closing PR. |
Clyybber
pushed a commit
to Clyybber/Nim
that referenced
this pull request
Sep 16, 2023
## Summary Always include support for logging the VM bytecode generated during compile-time execution in the compiler. `-d:expandVmListing` is re-used for selecting what to output. In addition, the feature is decoupled from the legacy reporting machinery. The goal is improve the debugging experience when working on the VM, by not having to temporarily re-build the compiler with `nimVMDebugGenerate` when wanting to log the the generated bytecode. ## Details * move rendering of VM code listing from `cli_reporter` to `vmutils`, with some minor code-style adjustments applied * add the `logBytecode` procedure to the `compilerbridge` module. It is responsible for deciding what to render, invoking the renderer, and writing the result to the output (via `msgWrite`) * call `logBytecode` whenever new bytecode becomes available * remove the `rdbgVmCodeListing` report, the data types related to it, and the special handling for it in `options` * change `codeListing` to be a proc, as it doesn't adhere to the "strict funcs" requirements * remove all usages of `nimVMDebugGenerate` * update the feature's documentation in `debug.rst` The key difference that allows for always including the logging support is that a code listing is only created when it's meant to be rendered. Previously, a listing was created for *all* code (even if it was only discarded afterwards), which introduced non-negligible overhead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very simple first bug fix :) Tested with: