Fixes #854 #857
Merged
Fixes #854 #857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clyybber
pushed a commit
to Clyybber/Nim
that referenced
this pull request
Sep 16, 2023
## Summary Move detection of inaccessible locals from `vmgen` into a pre-pass over standalone expressions/statements passed to compile-time execution. This makes sure that all locals reaching `transf` and the MIR phase are valid, which is a requirement for moving away from using `PSym` for locals in the code generators. ## Details - implement the check for whether unavailable locals are accessed in the new `semcomptime` module - integrate the check into `evalConstExprAux`, where it short-circuits code generation in case of an error - add a dedicated diagnostic for using unavailable locals in compile- time contexts (`adSemUnavailableLocation`/`rsemUnavailableLocation`) - adjust the tests using the old error message - remove from `vmgen` the checks regarding whether access of a local is valid Implementation-wise, the check works by traversing the AST, registering all symbols in a set as they're declared, and then, on use, checking whether non-global symbol are present in the set. If not, the node with the problematic symbol is propagated back to the callsite, where it is wrapped in an error node. While it would be possible to integrate the check into `sempass2`, the future of the latter isn't entirely clear and the pass is at present also not run for standalone compile-time expressions/statements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicit implementation of
==, since the implicit one errors out.