removed explicit return in the documentation #867
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Araq
added a commit
that referenced
this pull request
Feb 9, 2014
removed explicit return in the documentation
Araq
added a commit
that referenced
this pull request
Apr 7, 2014
removed explicit return in the documentation
Clyybber
pushed a commit
to Clyybber/Nim
that referenced
this pull request
Sep 16, 2023
## Summary Clarify the specification regarding how `when` statements within generic object definitions work and adjust the implementation accordingly. `when` statements inside generic object definitions are now treated as generic. This is a breaking change, but it makes using generic parameters in more complex expressions possible. Most notably, `isnot` now works properly inside generic objects' `when` conditions. ## Details * process `nkElifBranch` conditions of `nkWhenStmt` nodes within generic objects via `semGenericStmt` when analyzing the definition * remove the redundant AST checks in `replaceObjBranches` and `replaceTypeVarsN`; the already take place in `semRecordNode` * use `semConstBoolExpr` instead of `semConstExpr` when evaluating generic `when` conditions * `semConstBoolExpr` not returning an `nkIntLit` happens in case of cascading errors, so don't treat this as an internal error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.