osproc: increase stack size from 8k to 64k and disable useClone default #953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Araq
added a commit
that referenced
this pull request
Feb 23, 2014
osproc: increase stack size from 8k to 64k and disable useClone default
Araq
added a commit
that referenced
this pull request
Apr 7, 2014
osproc: increase stack size from 8k to 64k and disable useClone default
Clyybber
pushed a commit
to Clyybber/Nim
that referenced
this pull request
Oct 19, 2023
## Summary `suggest` correctly falls back to treating the project module as the parent module for out of project files/modules. ## Details Prior to this change, querying the parent module for a file that is not the project or a dependent module in the the project (via `import` or `include`), resulted in a returning a file index of `0`. This resulted in the parent being treated as the config file (typically first to get indexed). After this change, parent module querying, via `parentModule`, where no parent is found results in an `InvalidFileIdx`. Since this is used as part of suggest we continue to make progress by assuming the project module is the parent module and continue semantic analysis. As part of this change a regression test was added to ensure this continues to work. --------- Co-authored-by: Saem Ghani <saemghani+github@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that stack size for thread started by clone was too small.