Allocation overloads #977
Merged
Allocation overloads #977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you also add tests for the typedesc based procs? |
|
Aren't they included? Also, are there any additional assertions I can make? |
|
Ah, Sorry - I don't know where I was looking. |
|
It would be nice to have some usage examples with comments in the documentation. |
Clyybber
added a commit
to Clyybber/Nim
that referenced
this pull request
Oct 19, 2023
## Summary * Removed two node flags unused after the VM rework, which reduced the size of `TNodeFlags` to 2 bytes * Moved the `id` field below `typ` because `typ` requires an alignment of 8 bytes, while `id` has a size of 8 bytes * The two changes above combined result in reducing the size of `TNode` from 48 to 40 bytes on a x86_64 system ## Details * More node flags can be removed/moved from `TNodeFlag` , but that won't reduce the size of `TNode` further (unless they are reduced to only 8 node flags), so I'll make a seperate PR for those --------- Co-authored-by: zerbina <100542850+zerbina@users.noreply.github.com> Co-authored-by: Saem Ghani <saemghani+github@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All good?