Added comment explaining 'assert_numbits' error. #978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Araq
added a commit
that referenced
this pull request
Mar 6, 2014
Added comment explaining 'assert_numbits' error.
Araq
added a commit
that referenced
this pull request
Apr 7, 2014
Added comment explaining 'assert_numbits' error.
Clyybber
pushed a commit
to Clyybber/Nim
that referenced
this pull request
Oct 20, 2023
## Summary Fix generic parameter symbols not being resolved in forwarded generic routines that are instantiated before the generic routine is completed. This led to overload resolution failures or internal compiler errors. ## Details Instantiations created of a forwarded generic routines prior to the body existing are incomplete and need to be fixed-up once the body is available. This is done by `fixupInstantiatedSymbols`, but the instantiated generic parameters weren't added to the scope, which meant that the non-instantiated ones previously added to the scope by `semProcAux` were used. The symbols aren't persisted in the `TInstantiation`, only the types are, so they need to be created again. The logic for doing so is split out from `instantiateGenericParamList` into the standalone `instantiateGenericParam`, which `fixupInstantiatedSymbols` then uses to create the instantiated generic parameter symbols to add to the scope.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on IRC.