Check there are no side effects before optimizing away compile time e… #9934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm seeing the following test failure on Travis: This is the test file I added as part of the PR. Running |
|
You should be able to reproduce this with |
Araq
reviewed
Dec 20, 2018
compiler/semexprs.nim
Outdated
| if result.isNil: | ||
| localError(c.config, n.info, errCannotInterpretNodeX % renderTree(call)) | ||
| else: result = fixupTypeAfterEval(c, result, n) | ||
| if c.inStaticContext == 0: evalNow() |
There was a problem hiding this comment.
- This doesn't require a template as the condition can use an
oroperator. - The condition should be
c.inStaticContext > 0, no?
There was a problem hiding this comment.
- Fixed
- No, the idea is that if this expression is part of a larger compile time construct like
blockorwhenetc. evaluating it now in the presence of compile time side effects will cause the reported problem.
krux02
reviewed
Dec 21, 2018
tests/vm/tcompiletimesideeffects.nim
Outdated
| runNTimes(3, fill()) | ||
| echo C3 | ||
|
|
||
| # invoke fill() at runtime. |
There was a problem hiding this comment.
This comment is wrong. Fill is compile time only. It may not be called at runtime, and it isn't. The expression fill() is substituted by it's result during compilation.
|
@Araq The comments have been addressed, any chance this can be merged in? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…xpressions.
Fixes #9817.