Change to pass extra parameters to compiler #347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Didn't review the implementation, but this feature is important. |
|
The second commit is labelled wrong. It should read "Removed excess releaseOpt variable since args are passed in" or something similar. I've never made a pull request before so I'm not sure how to fix it. Would |
dom96
reviewed
May 5, 2017
| addRevDep(options, i, pkginfo) | ||
|
|
||
| proc buildFromDir(pkgInfo: PackageInfo, paths: seq[string], forRelease: bool) = | ||
| proc buildFromDir(pkgInfo: PackageInfo, paths: seq[string], args: var string) = |
There was a problem hiding this comment.
I would prefer if this took seq[string]
|
But i'll merge anyway. |
|
Thanks for the PR! |
|
Thanks for the merge :). I agree that the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes
nimble buildto pass along extra command line arguments to the compiler as mentioned in #334. Please let me know if there's anything I can change to make it better.