Skip to content

Add link to the Pull request after nim publish #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 4, 2018
Merged

Add link to the Pull request after nim publish #483

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ad37af7
Add link to the pull requests page
xmonader May 4, 2018
28f0a42
Add version bump
xmonader May 4, 2018
e7ff80a
inline PR url in the nim publish output
xmonader May 4, 2018
4c6e1b2
Small fixes on top of PR.
dom96 May 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/nimblepkg/common.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,4 +63,4 @@ when not defined(nimscript):
return (error, hint)

const
nimbleVersion* = "0.8.10"
nimbleVersion* = "0.8.11"
10 changes: 6 additions & 4 deletions src/nimblepkg/publish.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,11 +94,13 @@ proc createFork(a: Auth) =
raise newException(NimbleError, "Unable to create fork. Access token" &
" might not have enough permissions.")

proc createPullRequest(a: Auth, packageName, branch: string) =
proc createPullRequest(a: Auth, packageName, branch: string): string =
display("Info", "Creating PR", priority = HighPriority)
discard a.http.postContent(ReposUrl & "nim-lang/packages/pulls",
var body = a.http.postContent(ReposUrl & "nim-lang/packages/pulls",
body="""{"title": "Add package $1", "head": "$2:$3",
"base": "master"}""" % [packageName, a.user, branch])
var pr = parseJson(body)
return pr{"html_url"}.getStr()

proc `%`(s: openArray[string]): JsonNode =
result = newJArray()
Expand Down Expand Up @@ -220,5 +222,5 @@ proc publish*(p: PackageInfo, o: Options) =
doCmd("git commit packages.json -m \"Added package " & p.name & "\"")
display("Pushing", "to remote of fork.", priority = HighPriority)
doCmd("git push https://" & auth.token & "@github.com/" & auth.user & "/packages " & branchName)
createPullRequest(auth, p.name, branchName)
display("Success:", "Pull request successful.", Success, HighPriority)
let prUrl = createPullRequest(auth, p.name, branchName)
display("Success:", "Pull request successful, check at " & prUrl , Success, HighPriority)