Skip to content

Fixed getPkgDir #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 31, 2018
Merged

Fixed getPkgDir #497

merged 1 commit into from
May 31, 2018

Conversation

yglukhov
Copy link
Member

No description provided.

@dom96 dom96 merged commit 8c57227 into nim-lang:master May 31, 2018
@yglukhov yglukhov deleted the fix-getPkgDir branch May 31, 2018 12:11
@genotrance
Copy link
Contributor

Curious on this - getPkgDir() is not documented in nimscript nor nimble. How are users expected to find this and use it?

Meanwhile, thisDir() does exist in nimscript and is documented, just fixed it in #827.

cc @alaviss @dom96

@dom96
Copy link
Collaborator

dom96 commented Jul 26, 2020

Hrm, perhaps getPkgDir predates it? But yeah, docs would have been nice.

@genotrance
Copy link
Contributor

Considering its not documented, I propose deprecating getPkgDir() and eventually remove.

@dom96
Copy link
Collaborator

dom96 commented Jul 27, 2020

CC @yglukhov

@yglukhov
Copy link
Member Author

Considering its not documented, I propose deprecating getPkgDir() and eventually remove.

Fine by me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yglukhov @genotrance @dom96