Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Github Actions CI using choosenim #877

Merged
merged 3 commits into from Nov 20, 2020
Merged

Conversation

iffy
Copy link
Contributor

@iffy iffy commented Nov 18, 2020

This is yet another alternative for switching from Travis to Github Actions. It supersedes #871 and #868 with the following differences:

You can see the build run for this PR here: https://github.com/iffy/nimble/actions/runs/370324359

I apologize for making 3 PRs for this issue, but they haven't followed a sequential pattern of development.

Copy link
Collaborator

@dom96 dom96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Do I dare look at the implementation of iffy/install-nim? :)

- 1.0.10
- 1.2.8
- 1.4.0
- git:8a004e2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this just a demo? :)

Pretty cool, but we don't need this here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mimics the current Travis build: https://github.com/nim-lang/nimble/blob/master/.travis.yml#L13 I'm fine removing it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, it's either this or the nightly. We don't need both. If the nightly works and is newer let's keep it instead of this.

- 1.2.8
- 1.4.0
- git:8a004e2
- nightly:https://github.com/nim-lang/nightlies/releases/tag/2020-11-11-devel-bbe49a14ae827b6474d692042406716a3b3dd71f
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing choosenim is not used for this case?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. If there's a something: prefix, choosenim is not used.

@iffy
Copy link
Contributor Author

iffy commented Nov 19, 2020

Cool. Do I dare look at the implementation of iffy/install-nim? :)

Nope, you'd better not :) The car runs -- don't pop the hood. (Hint: it's pretty much that script from the last PR)

@iffy
Copy link
Contributor Author

iffy commented Nov 19, 2020

Don't merge yet -- nightly isn't working. I'll fix it.

@iffy
Copy link
Contributor Author

iffy commented Nov 19, 2020

Okay, now nightly is building right: https://github.com/iffy/nimble/actions/runs/373098791

@dom96
Copy link
Collaborator

dom96 commented Nov 20, 2020

Epic, thanks!

@dom96 dom96 merged commit e658bb5 into nim-lang:master Nov 20, 2020
@iffy iffy deleted the ci-choosenim branch November 21, 2020 03:11
This was referenced Nov 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants