Skip to content

Conversation

data-man
Copy link
Contributor

No description provided.

@data-man data-man closed this May 12, 2018
@data-man data-man reopened this May 12, 2018
@data-man data-man closed this May 12, 2018
@dom96 dom96 reopened this May 12, 2018
@dom96 dom96 merged commit b297ddb into nim-lang:master May 12, 2018
@dom96
Copy link
Contributor

dom96 commented May 12, 2018

Not sure why you closed this. Your package is pretty much perfect, even has a beautiful readme ;)

One thing I would change is not include the C sources in the repo (add a git submodule instead).

@data-man
Copy link
Contributor Author

data-man commented May 12, 2018

@dom96

has a beautiful readme

Took somewhere. I'm not sure as licensed this readme. :)

not include the C sources

In the author's repo are a few unnecessary files (for this package).

pmetras pushed a commit to pmetras/packages that referenced this pull request Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants