Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added forkme ribbon #86

Merged
merged 1 commit into from
Jun 7, 2018
Merged

Added forkme ribbon #86

merged 1 commit into from
Jun 7, 2018

Conversation

yglukhov
Copy link
Member

No description provided.

@dom96
Copy link
Contributor

dom96 commented May 23, 2018

@Araq You happy with this?

@Araq
Copy link
Member

Araq commented May 24, 2018

I'm not against it, but where do you see the benefits? Do we want people to fork Nim? It is just to be cool? Neither Python's nor Ruby's website have this ribbon, Rust does. IMO it's mildly unprofessional, why would I need to fork a programming language implementation...

@yglukhov
Copy link
Member Author

It is recognizable and hopefully will drive more people to star the project

@Araq
Copy link
Member

Araq commented May 24, 2018

Alright then.

@Calinou
Copy link
Member

Calinou commented May 24, 2018

I don't really like the "fork me on GitHub" ribbons, they feel old-fashioned to me. Not to mention even GitHub itself doesn't encourage its use anymore 😃

@wooster0
Copy link
Contributor

I don't like it either :/ imagine this ribbon on https://nim-lang.org:
Fork me on GitHub
It would maybe block some buttons and generally it just doesn't fits to the style of the website. It doesn't looks really fancy. I would rather add a "GitHub" button next to the "Donate" button.

@yglukhov
Copy link
Member Author

Here's the actual image of what it looks like:
screen shot 2018-05-24 at 8 49 38 pm
Yay or nay?

@dom96
Copy link
Contributor

dom96 commented May 24, 2018

Fits the colour scheme surprisingly well :)

So i'm happy to add it as a trial.

I would still prefer a little button with a counter and a star icon next to it, maybe beside the "Install" button or somewhere else.

@dom96 dom96 merged commit 2934085 into nim-lang:master Jun 7, 2018
@dom96
Copy link
Contributor

dom96 commented Jun 7, 2018

Gonna publish this as a trial :)

Calinou pushed a commit to Calinou/website that referenced this pull request Jul 23, 2019
Add an User Groups page that lists local communities
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants