Permalink
Browse files

Proposed workaround for buggy Xen/libvirt VM state

The default Xen/libvirt on RHEL5 occasionally reports VMs as DOM_STATE_NOSTATE. The cause is not clear but anecdotally it seems to be related to multiple VMs running on a node. Previously, ws-control treated these VMs as not found which led to zombie VMs. 

This change causes info() calls to report such VMs as known but without a state.
  • Loading branch information...
1 parent 1c5202b commit e5275d1ade4925607982f2b450f509f5c45fcf6f @labisso labisso committed Nov 17, 2010
Showing with 1 addition and 1 deletion.
  1. +1 −1 control/src/python/workspacecontrol/defaults/lvrt/lvrt_common.py
@@ -248,7 +248,7 @@ def info(self, handle):
if state == DOM_STATE_NOSTATE:
# this is the case right after a graceful shutdown succeeds
self.c.log.debug("found VM with name '%s' but it has no state -- from the perspective 'above' this means it was not found at all." % handle)
- return None
+ return rvm
if state == DOM_STATE_RUNNING:
rvm.running = True

0 comments on commit e5275d1

Please sign in to comment.