One possible bug in HDFS unpropagation #100

Closed
priteau opened this Issue Jun 11, 2012 · 0 comments

Comments

Projects
None yet
1 participant
@priteau
Member

priteau commented Jun 11, 2012

Bug reported by Brett Wu on workspace-user.

In the file, $NIMBUS_IAAS_CONTROLS/src/python/workspacecontrol/defaults/imageprocurement/propagate_hdfs.py,

104 def unpropagate(self, local_absolute_source, remote_target):
105 self.c.log.info("HDFS unpropagation - local target: %s" % local_absolute_target)
106 self.c.log.info("HDFS unpropagation - remote source: %s" % remote_source)
107
108 cmd = self.__generate_hdfs_push_cmd(remote_source, local_absolute_target)

apparently, it should be

104 def unpropagate(self, local_absolute_source, remote_target):
105 self.c.log.info("HDFS unpropagation - local target: %s" % local_absolute_source)
106 self.c.log.info("HDFS unpropagation - remote source: %s" % remote_target)
107
108 cmd = self.__generate_hdfs_push_cmd(local_absolute_source, remote_target)

Correspondingly, we should also update

142 def __generate_hdfs_push_cmd(self, remote_target, local_absolute_target):
143 # Generate command in the form of:
144 # /path/to/hadoop/bin/hadoop fs -fs -copyFromLocal

as

142 def __generate_hdfs_push_cmd(self, local_absolute_target, remote_target):
143 # Generate command in the form of:
144 # /path/to/hadoop/bin/hadoop fs -fs -copyFromLocal

After these updates, testing on "--unpropagate" works fine.

@ghost ghost assigned priteau Jun 12, 2012

@priteau priteau closed this in 32d323d Jul 3, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment