Allow Cross Server Redirects in https staging #114

Closed
oldpatricka opened this Issue Aug 16, 2012 · 2 comments

Comments

Projects
None yet
1 participant
@oldpatricka
Member

oldpatricka commented Aug 16, 2012

This is disabled right here: https://github.com/nimbusproject/nimbus/blob/master/control/src/python/workspacecontrol/defaults/imageprocurement/propagate_https.py#L185

I don't see any reason we shouldn't allow this. Does anyone have any objections?

@oldpatricka

This comment has been minimized.

Show comment
Hide comment
@oldpatricka

oldpatricka Aug 17, 2012

Member

As discussed on Campfire, the solution to this will be:

  • Print a warning when a cross-server redirect is followed
  • Add an option to disable cross server redirects
  • Add a warning in the whitelist section of global-policy.conf that redirects can be followed.
Member

oldpatricka commented Aug 17, 2012

As discussed on Campfire, the solution to this will be:

  • Print a warning when a cross-server redirect is followed
  • Add an option to disable cross server redirects
  • Add a warning in the whitelist section of global-policy.conf that redirects can be followed.

@ghost ghost assigned oldpatricka Aug 17, 2012

@oldpatricka

This comment has been minimized.

Show comment
Hide comment
@oldpatricka

oldpatricka Aug 20, 2012

Member

This issue is fixed in c611a8f (and 2652487, sigh)

Member

oldpatricka commented Aug 20, 2012

This issue is fixed in c611a8f (and 2652487, sigh)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment