Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Allow Cross Server Redirects in https staging #114

Closed
oldpatricka opened this Issue · 2 comments

1 participant

Patrick Armstrong
Patrick Armstrong
Collaborator

This is disabled right here: https://github.com/nimbusproject/nimbus/blob/master/control/src/python/workspacecontrol/defaults/imageprocurement/propagate_https.py#L185

I don't see any reason we shouldn't allow this. Does anyone have any objections?

Patrick Armstrong
Collaborator

As discussed on Campfire, the solution to this will be:

  • Print a warning when a cross-server redirect is followed
  • Add an option to disable cross server redirects
  • Add a warning in the whitelist section of global-policy.conf that redirects can be followed.
Patrick Armstrong oldpatricka was assigned
Patrick Armstrong
Collaborator

This issue is fixed in c611a8f (and 2652487, sigh)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.