Skip to content

Adding a partition Label to the created blankspace partition #88

Closed
wants to merge 2 commits into from

3 participants

@mhpx
mhpx commented Feb 17, 2012

A Label on the blankspace partition will allow mounting via Label instead of
device, this makes it easier in fstab where the device of the blankspace partition may change.

@mhpx mhpx Add a label to the created blankspace partition
A Label on the blankspace partition will allow mounting via Label instead of
device, this makes it easier in fstab where the device of the blankspace partition may not be known a priori.
602192e
@priteau
Nimbus member
priteau commented Feb 17, 2012

You wrote 'blankspce' instead of 'blankspace'. Is it a typo?

@mhpx
mhpx commented Feb 17, 2012

yea that's a typo. /sigh

@igable
Nimbus member
igable commented Feb 17, 2012

At UVic we discovered that you can get different devices depending on weather you boot the same image on KVM or Xen. If you don't use a lable you have to hard code the device into the fstab, which then fails if you change hypervisors.

@priteau priteau was assigned Jun 19, 2012
@priteau
Nimbus member
priteau commented Jun 29, 2012

I am reviewing this feature for inclusion in the next Nimbus release.

One problem I see is that if multiple blankspace partitions are defined, they will all have the same label. If I manage to make the blank partition labelled with the name defined in the XML with <partitionName>, would it still be useful for you?

@priteau
Nimbus member
priteau commented Jun 29, 2012

Another option is to use the internal name known by workspace-control: blankpartition0, blankpartition1, etc.

@mhpx
mhpx commented Jun 29, 2012

We've only ever used a single blankspace partition per VM. (Not sure we were even aware using multiple was possible) The feature is desirable to us for the reason Ian stated above. Either way would work, we still make use of the reference client / xml for managing VMs, or an incremental name within workspace-control works too. Whatever the path of least resistance is.

@priteau
Nimbus member
priteau commented Jun 29, 2012

Thank you Michael for your answer. Incremental name within workspace-control it will be.

@priteau priteau added a commit that closed this pull request Jun 29, 2012
@priteau priteau Add a partition label to each blankspace partition
Labels are extracted from the partition file name, and are named
incrementally: blankpartition0, blankpartition1, etc.

A label on the blankspace partition will allow mounting via label
instead of device. This makes it easier in fstab where the device of the
blankspace partition may not be known a priori.

Thanks to Michael Paterson for the feature request and initial patch.

Closes #88.
1ebff8c
@priteau priteau closed this in 1ebff8c Jun 29, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.