Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mod_auth_openidc as option #2

Merged
merged 1 commit into from Feb 10, 2020
Merged

Add mod_auth_openidc as option #2

merged 1 commit into from Feb 10, 2020

Conversation

@neckhair
Copy link
Member

neckhair commented Feb 10, 2020

This PR adds the possibility to use mod-auth-openidc for OpenID Connect authentication on the proxy level. It kind of has the same behavior as the existing mod-auth-cas integration.

The new configuration options are:

@thde
thde approved these changes Feb 10, 2020
Copy link

thde left a comment

LGTM

@@ -50,10 +50,27 @@ CustomLog /dev/stdout combined
CASValidateURL <%= ENV['CAS_VALIDATE_URL'] %>
CASProxyValidateURL <%= ENV['CAS_PROXY_VALIDATE_URL'] %>
CASRootProxiedAs <%= ENV['CAS_SERVICE_URL'] %>
<%- end -%>

<%- if ENV['OIDC_ENABLED'] == '1' -%>

This comment has been minimized.

Copy link
@thde

thde Feb 10, 2020

I'd prefer true instead of 1.

This comment has been minimized.

Copy link
@neckhair

neckhair Feb 10, 2020

Author Member

Tried to keep it consistent with the existing CAS_ENABLED variable.

@neckhair neckhair merged commit b636bfc into master Feb 10, 2020
@neckhair neckhair deleted the oidc branch Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.