Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Stop filtering ssl options, or allow all valid ssl options #49

Closed
archaelus opened this Issue · 2 comments

2 participants

@archaelus

Related to #34, ranch_ssl currently requires certfile as a transport option, but this is only one way that the Erlang SSL library can be configured for certs.

I am trying to programmatically generate certs for a ranch/cowboy based application and use the ssl cert, key, cacerts ssl options, but ranch_ssl both tests for certfile which I don't pass, and filters out the mentioned options.

I can write a patch for this if required - do you want one that completely relaxes the option validation, and filtering, or do you want a patch that specifically tests for cert or certfile, and additionally allows cert, key, cacerts through the option filtering?

@essen
Owner

Last one. We shouldn't accept some of the options like 'packet' for example.

@essen
Owner

Closing since it has been merged. Thanks!

@essen essen closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.