Fix trivial mistake when counting the number of active connections

ning · Jul 23, 2010 · 531c59a · 531c59a · jfarcand · Jul 23, 2010
1 parent a67540d
commit 531c59a
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/src/main/java/com/ning/http/client/providers/NettyAsyncHttpProvider.java b/src/main/java/com/ning/http/client/providers/NettyAsyncHttpProvider.java
@@ -460,7 +460,8 @@ private <T> Future<T> doConnect(final Request request, final AsyncHandler<T> asy
         }
 
 
-        if (config.getMaxTotalConnections() != -1 && activeConnectionsCount.getAndIncrement()>= config.getMaxTotalConnections()) {
+        if (config.getMaxTotalConnections() != -1 && activeConnectionsCount.getAndIncrement() >= config.getMaxTotalConnections()) {
+            activeConnectionsCount.decrementAndGet();
             throw new IOException("Too many connections");
         }
 
@@ -646,6 +647,7 @@ private void markAsDoneAndCacheConnection(final NettyResponseFuture<?> future, f
             if (connectionPerHost.getAndIncrement() < config.getMaxConnectionPerHost()) {
                 connectionsPool.put(getBaseUrl(future.getURI()), channel);
             } else {
+                connectionPerHost.decrementAndGet();
                 log.warn("Maximum connections per hosts reached " + config.getMaxConnectionPerHost());
             }
         } else {