Browse files

Merge pull request #479 from nico/testfix

ManifestParser constructor accesses its first argument, don't pass NULL
  • Loading branch information...
2 parents 37b5ac7 + 0fd3797 commit 8a4c9e05f794162af46939e078ee6464367cafc9 @evmar evmar committed Jan 2, 2013
Showing with 6 additions and 3 deletions.
  1. +6 −3 src/manifest_parser_test.cc
View
9 src/manifest_parser_test.cc
@@ -295,7 +295,8 @@ TEST_F(ParserTest, ReservedWords) {
TEST_F(ParserTest, Errors) {
{
- ManifestParser parser(NULL, NULL);
+ State state;
+ ManifestParser parser(&state, NULL);
string err;
EXPECT_FALSE(parser.ParseTest("foobar", &err));
EXPECT_EQ("input:1: expected '=', got eof\n"
@@ -305,7 +306,8 @@ TEST_F(ParserTest, Errors) {
}
{
- ManifestParser parser(NULL, NULL);
+ State state;
+ ManifestParser parser(&state, NULL);
string err;
EXPECT_FALSE(parser.ParseTest("x 3", &err));
EXPECT_EQ("input:1: expected '=', got identifier\n"
@@ -315,7 +317,8 @@ TEST_F(ParserTest, Errors) {
}
{
- ManifestParser parser(NULL, NULL);
+ State state;
+ ManifestParser parser(&state, NULL);
string err;
EXPECT_FALSE(parser.ParseTest("x = 3", &err));
EXPECT_EQ("input:1: unexpected EOF\n"

0 comments on commit 8a4c9e0

Please sign in to comment.