Error setting builddir to a nested path which doesn't yet exist #392

Closed
rgeary1 opened this Issue Aug 1, 2012 · 0 comments

2 participants

@rgeary1

The following build.ninja code fails, as ninja doesn't do a recursive directory create for the builddir directory.
Caused by MakeDir in ninja.cc line 749.

repo:

build.ninja :
builddir = some/big/path

error message :
ninja : error: creating build directory some/big/path: No such file or directory
@rgeary1 rgeary1 added a commit to rgeary1/ninja that referenced this issue Aug 3, 2012
@rgeary1 rgeary1 Fix for bug #392, ninja fails to recursively create the builddir
Change-Id: I1f98a4eb9c23ff5a215964b3bd89243d80cd0de1
6184a6b
@evmar evmar added a commit that referenced this issue Aug 7, 2012
@evmar evmar use DiskInterface to create the build directory
Fixes issue #392 (didn't handle creating nested build dirs right).

Moves MakeDir out of util.h; all code should go through
DiskInterface to simplify testing.  Moves ownership of the
DiskInterface into the client of the Builder, which also allows
removing some code that reached inside the object as well as
a minor leak.
cc222d3
@evmar evmar closed this Aug 7, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment