-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FreeBSD supports ppoll(2) #1185
Conversation
|
ppoll() is available only on FreeBSD 10.2 and up, but not on older, but still supported releases. |
|
You are right. Let's keep this here until we EOL older releases. |
|
Is there a way to test the FreeBSD version at compile-time? (E.g. an ifdef?) |
|
#include <osreldate.h> |
|
It's in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
| @@ -24,6 +24,13 @@ | |||
| #include <sys/wait.h> | |||
| #include <spawn.h> | |||
|
|
|||
| #ifdef __FreeBSD__ | |||
| # include <sys/param.h> | |||
| # if defined USE_PPOLL && __FreeBSD_version < 1002000 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fwiw we don't put spaces between # and the word after it in ninja; maybe you can zap them in a follow-up
|
Done in #1187 |
This also fixes this test error
SubprocessTest.SetWithLotsninja: fatal: pipe: Too many open filescaused byin Subprocess::Start