Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_issue_1418 to pass on 1-core VM #1651

Merged
merged 1 commit into from Sep 20, 2019

Conversation

@bmwiedemann
Copy link
Contributor

commented Sep 20, 2019

the previous assert would fail because on a 1-core VM, the 3 outputs
were produced sequentially from top to bottom

This PR was done while working on reproducible builds for openSUSE.

@jhasse

This comment has been minimized.

Copy link
Collaborator

commented Sep 20, 2019

Or pass -j3 to ninja?

the previous assert would fail because on a 1-core VM, the 3 outputs
were produced sequentially from top to bottom
@bmwiedemann

This comment has been minimized.

Copy link
Contributor Author

commented Sep 20, 2019

Updated it. This is related to #1418

@jhasse jhasse merged commit 2321fd7 into ninja-build:master Sep 20, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bmwiedemann bmwiedemann deleted the bmwiedemann:onecore branch Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.