Do not reset restat_mtime if an input is missing #313

Merged
merged 2 commits into from Jul 3, 2012

Projects

None yet

5 participants

@wolfp

See discussion for Issue #295.

@evmar

Can you write a test?

@pcc

Other than that, LGTM with a test.

@ClausKlein

While my tests with ninja, I was wondering why the restat_mtime is reseted?
What is the use case for the old code?

IMO the restat is missing good tests at all.

@buildhive

Evan Martin » ninja #24 FAILURE
Looks like there's a problem with this pull request
(what's this?)

@buildhive

Evan Martin » ninja #25 FAILURE
Looks like there's a problem with this pull request
(what's this?)

@buildhive

Evan Martin » ninja #26 SUCCESS
This pull request looks good
(what's this?)

@evmar evmar merged commit 0ca93ba into ninja-build:master Jul 3, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment