bootstrap: fix path magic on windows #325

Merged
merged 1 commit into from Jun 12, 2012

Conversation

Projects
None yet
3 participants
Contributor

philips commented Jun 11, 2012

It was reported that argv[0] doesn't get set on windows. Some research
showed that using abspath(filename) should accomplish this.

Brandon Philips bootstrap: fix path magic on windows
It was reported that argv[0] doesn't get set on windows. Some research
showed that using abspath(__filename__) should accomplish this.
b191336
Collaborator

nico commented Jun 11, 2012

This helps. Note that this is unrelated to windows, it was broken on Linux and OS X too.

Contributor

philips commented Jun 11, 2012

@nico Weird. I tested it on OSX and Linux. What version of python? I was doing a os.system to execute the script.

Collaborator

nico commented Jun 12, 2012

@philips You need to run python bootstrap.py, not ./bootstrap.py to repro.

Contributor

philips commented Jun 12, 2012

@nico Ah! Duh :-/ I only run python bootstrap in my Win32 code path.

@evmar evmar added a commit that referenced this pull request Jun 12, 2012

@evmar evmar Merge pull request #325 from luvit/fix-path-magic
bootstrap: fix path magic on windows
2867bbc

@evmar evmar merged commit 2867bbc into ninja-build:master Jun 12, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment