Buffer size passed to snprintf is wrong in rate code #419

Merged
merged 3 commits into from Sep 18, 2012

Conversation

Projects
None yet
3 participants
@syntheticpp
Contributor

syntheticpp commented Sep 15, 2012

No description provided.

@buildhive

This comment has been minimized.

Show comment Hide comment
@buildhive

buildhive Sep 15, 2012

Evan Martin » ninja #169 SUCCESS
This pull request looks good
(what's this?)

Evan Martin » ninja #169 SUCCESS
This pull request looks good
(what's this?)

syntheticpp added some commits Sep 18, 2012

Fix subtile buffer size error
The deduced type was char* with size 4 and not char[32] with size 32.
This removes strange output characters on Windows.
@syntheticpp

This comment has been minimized.

Show comment Hide comment
@syntheticpp

syntheticpp Sep 18, 2012

Contributor

Yes, inheritance is maybe not necessary here, at least complicates reading the code.

I push another patch which makes the code more 'symmetric' and readable.

Contributor

syntheticpp commented Sep 18, 2012

Yes, inheritance is maybe not necessary here, at least complicates reading the code.

I push another patch which makes the code more 'symmetric' and readable.

@buildhive

This comment has been minimized.

Show comment Hide comment
@buildhive

buildhive Sep 18, 2012

Evan Martin » ninja #173 SUCCESS
This pull request looks good
(what's this?)

Evan Martin » ninja #173 SUCCESS
This pull request looks good
(what's this?)

evmar added a commit that referenced this pull request Sep 18, 2012

Merge pull request #419 from syntheticpp/rate-buffer-size
Buffer size passed to snprintf is wrong in rate code

@evmar evmar merged commit e6c8bd9 into ninja-build:master Sep 18, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment