State test lookup #501

Closed
wants to merge 2 commits into
from

Projects

None yet

4 participants

@tfarina
Contributor
tfarina commented Feb 18, 2013

No description provided.

tfarina added some commits Feb 18, 2013
@tfarina tfarina Add test for State::LookupRule() function.
TEST=ninja_test --gtest_filter=State.Basic

Signed-off-by: Thiago Farina <tfarina@chromium.org>
6d7e0ca
@tfarina tfarina free edge
Signed-off-by: Thiago Farina <tfarina@chromium.org>
eb143ea
@buildhive

Evan Martin » ninja #316 SUCCESS
This pull request looks good
(what's this?)

@evmar

This isn't right; the edges are owned by the State object.

Owner
@nico
Collaborator
nico commented Dec 4, 2014

I think Evan meant that it's conceptually owned by State. If ninja cared about freeing memory (e.g. if we turn it into a library some day), State would grow a destructor that frees all the State's Nodes and Edges and Rules.

@nico nico closed this Dec 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment