Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Remove dependency of the core on javax.servlet #85
This is a breaking change but rather with limited impact:
This paves the way for supporting other containers, such as Netty or Grizzly.
TODO: move the test lib to an in-process model, possibly splitting the jetty-based implementation into its own module (or removing it entirely); similarly to how Jersey 2.0 provides several backends for tests.
looks really good.
Just one thing: Why did you add Result to the Session and Flash Scopes? When you finalize the headers the request stuff gets copied over automatically... https://github.com/reyez/ninja/blob/develop/ninja-core/src/main/java/ninja/servlet/ContextImpl.java and finalizeHeaders . Maybe I am missing something here...
Have a look at the changes in