Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What are your plans in creating and maintaining a Ninject adapter for the ASP.NET vNext DI system? #177

Open
dotnetjunkie opened this issue Jun 15, 2015 · 12 comments

Comments

@dotnetjunkie
Copy link

@dotnetjunkie dotnetjunkie commented Jun 15, 2015

I'm interested to know whether or not the Ninject team has decided to take over the maintenance of the ASP.NET DI adapter for Ninject that the ASP.NET team built.

As discussed by Mark Seemann here and on the Simple Injector forum (in discussion with David Fowler) here, implementing such adapter has some serious downsides; even for Ninject. The discussion on the Simple Injector forum also shows a very compelling alternative that is applicable for any possible DI container (and applicable when practicing Pure DI).

So I'm very interested to hear whether your team is planning to support such adapter, or whether you favor a guidance similar to given on the Simple Injector forum. I really like to hear your opinions and motivations behind this.

@dotnetjunkie dotnetjunkie changed the title What are your plans in creating an maintaining a Ninject adapter for the ASP.NET vNext DI system? What are your plans in creating and maintaining a Ninject adapter for the ASP.NET vNext DI system? Jun 15, 2015
@siberianguy
Copy link

@siberianguy siberianguy commented Dec 1, 2015

Any feedback on this would be highly appreciated. I'm now migrating my application to ASP.NET 5 and I'm confused whether I can use Ninject or not.

@dotnetjunkie
Copy link
Author

@dotnetjunkie dotnetjunkie commented Dec 1, 2015

You can -and should- continue to use Ninject. Whether an Ninject adapter for ASP.NET Core is created or not is irrelevant, because you should not use such adapter in your applications, as explained here.

@ciel
Copy link

@ciel ciel commented Jan 29, 2016

I'm still super lost on how to use Ninject with ASP.NET 5, specifically the Identity stuff.

@dotnetjunkie
Copy link
Author

@dotnetjunkie dotnetjunkie commented Jan 29, 2016

Take a look at this discussion on the Simple Injector forum. It describes how to integrate Identity Framework with SI and you'll find most (if not all) of it to be applicable to Ninject as well.

@AlexKeySmith
Copy link

@AlexKeySmith AlexKeySmith commented Mar 14, 2016

👍

I think an "official" response from the ninject core team would be very useful. It feels like autofac have made a statement with their choice of support. But I'm unsure if ninject's opinion, whether there currently isn't an adapter because it's the wrong thing to do (as SimpleInjector suggests) or whether it's something that's coming in the future.

As people begin to migrate their code to MVC 6 this question will come up a lot and it's an unknown at the moment probably making people consider autofac (rightly or wrongly) as there is an official response.

@BrunoJuchli
Copy link
Contributor

@BrunoJuchli BrunoJuchli commented Mar 21, 2016

there's not that much development going on with Ninject.. so i believe that the current maintainers are unlikely to do so. However, if anyone else starts his/her own project to create an adapter, i think this should be fine.

@AlexKeySmith
Copy link

@AlexKeySmith AlexKeySmith commented Mar 21, 2016

Thanks @BrunoJuchli for the input, I'm thinking the same thing. I wonder if the adapter is a good idea or not for ninject, there seems to be polarized view between the maintainers of Simple Injector and Autofac.

@ah-
Copy link

@ah- ah- commented Jun 27, 2016

Anyone interested in getting this working? ah-@b6820cb

@BrunoJuchli
Copy link
Contributor

@BrunoJuchli BrunoJuchli commented Jun 28, 2016

@ah- i don't understand what that has got to do with this issue. Could you please explain?

@hodzanassredin
Copy link

@hodzanassredin hodzanassredin commented Nov 14, 2016

Created demo project ninject + asp.net core here. It uses Missing-Core-DI-Extensions

@dotnetjunkie
Copy link
Author

@dotnetjunkie dotnetjunkie commented Nov 14, 2016

Hi @hodzanassredin,

Since you are using the Missing-Core-DI-Extensions, please consider sharing your experience with them on this thread. It's important for Microsoft to understand that the omission of these extensions is a problem for Ninject users as well and to know how well these integration points work.

@andreasohlund
Copy link

@andreasohlund andreasohlund commented Feb 7, 2020

We're starting the transition of our users (NServiceBus) over from our custom DI container adapters over to the "official" Microsoft dependency injection ones and was looking for the one for Ninject so that we can point users in this direction?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
8 participants
You can’t perform that action at this time.