Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Modern PCL project that also support CoreClr #200

Closed
wants to merge 7 commits into from

Conversation

@jeremymeng
Copy link

jeremymeng commented Nov 24, 2015

For #185
This is mostly a copy of the old portable csproj, with different targeted profile.

@@ -19,6 +19,22 @@
<summary>IoC container for .NET</summary>
<releaseNotes>Xamarin support for iOS and Android</releaseNotes>
<tags>Ninject ioc di portable pcl xamarin ios android monotouch monoandroid</tags>
<dependencies>
<group targetFramework="dotnet">

This comment has been minimized.

Copy link
@clairernovotny

clairernovotny Nov 24, 2015

I would recommend using NuSpec.ReferenceGenerator to add/update the dependencies as they can change over time and the tool will ensure they're up-to-date.

This comment has been minimized.

Copy link
@jeremymeng

jeremymeng Nov 24, 2015

Author

I actually tried. But for some reason it didn't work. NuSpec.ReferenceGenerator wasn't getting added to the project.json. I didn't have time to look into it yet.

@clairernovotny
Copy link

clairernovotny commented Nov 24, 2015

Can you please add a unit test project for DNX as well?

jeremymeng added 2 commits Nov 25, 2015
…Most of the changes are mimicing what WINRT project does.

Add a dnx test project.  It references the output of Ninject-dotnet project via a wrap project of "wrap\Ninject\project.json".  324 tests passed in VS, while 330 passed using "dnx test".  However this moq based tests are disabled by NO_MOQ for now since the official Moq doesn't support CoreClr yet.
@jeremymeng
Copy link
Author

jeremymeng commented Nov 25, 2015

Thanks for asking to add the test project. It revealed that I cannot just simply copy the PCL project.

@jeremymeng
Copy link
Author

jeremymeng commented Nov 25, 2015

Looks like the build machine doesn't support .Net 4.6.

@@ -424,6 +431,54 @@ Global
{420ACA2A-7853-4C5D-A3B1-E7AE938A801F}.Release|Mixed Platforms.ActiveCfg = Release|Any CPU
{420ACA2A-7853-4C5D-A3B1-E7AE938A801F}.Release|Mixed Platforms.Build.0 = Release|Any CPU
{420ACA2A-7853-4C5D-A3B1-E7AE938A801F}.Release|x86.ActiveCfg = Release|Any CPU
{00A3D52F-BA8F-49A3-BDF8-FA457E866F3A}.Debug|Any CPU.ActiveCfg = Debug|Any CPU

This comment has been minimized.

Copy link
@jeremymeng

jeremymeng Nov 25, 2015

Author

I don't understand why adding a Modern PCL project creates so many configurations.

@clairernovotny
Copy link

clairernovotny commented Nov 25, 2015

Working on the build machine. AppVeyor is setup but the current build server is interfering
https://ci.appveyor.com/project/onovotny/ninject

@jeremymeng
Copy link
Author

jeremymeng commented Dec 9, 2015

@onovotny is there anything I can do to move this PR forward?

@ah-
Copy link

ah- commented Apr 21, 2016

What's the status of this? I think the new infrastructure has now sufficiently stabilized to start building netstandard compatible packages.

A starting point might be ah-@b6820cb, would you accept an updated PR?

@jeremymeng
Copy link
Author

jeremymeng commented Aug 24, 2016

Closing as the master branch already has netstandard support.

@jeremymeng jeremymeng closed this Aug 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.