Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All annotations are useful #14

Merged
merged 1 commit into from Jul 16, 2018

Conversation

2 participants
@mabar
Copy link
Member

commented Jul 15, 2018

With this change will be comments with only doctrine annotations no more reported as useless.

Currently is reported:

/**
 * @Path("/users")
 * @Method("GET")
 */

Currently is NOT reported:

/**
 * Practically the same
 * @Path("/users")
 * @Method("GET")
 */
All annotations are useful
With this change will be comments with only doctrine annotations no more reported as useless.

Currently is reported:
```
	/**
	 * @path("/users")
	 * @method("GET")
	 */
```

Currently is *NOT* reported:
```
	/**
	 * Practically the same
	 * @path("/users")
	 * @method("GET")
	 */
```

@f3l1x f3l1x merged commit 5b827f9 into ninjify:master Jul 16, 2018

@f3l1x

This comment has been minimized.

Copy link
Member

commented Jul 16, 2018

Cool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.