Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude useless sniffs #15

Merged
merged 3 commits into from Aug 28, 2018

Conversation

2 participants
@mabar
Copy link
Member

commented Aug 28, 2018

ClosureNotStatic

  • requires all closures defined as static function(){}

UnusedParameter

  • ignores inheritance - reports unused parameters literally everywhere

NewWithoutParentheses

  • colliding with NewWithParentheses

UselessParenthesses

  • not always useless
    • sometimes are used for readability improvement
    • in some complicated cases removal breaks code

NoComma

  • colliding with MissingTrailingComma

@f3l1x f3l1x merged commit c14ff92 into ninjify:master Aug 28, 2018

@f3l1x

This comment has been minimized.

Copy link
Member

commented Aug 28, 2018

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.