Skip to content

[FIX] Correctly populate right-hemisphere time series in CIFTI derivatives#1378

Merged
effigies merged 1 commit intonipreps:masterfrom
sebnaze:master
Nov 12, 2018
Merged

[FIX] Correctly populate right-hemisphere time series in CIFTI derivatives#1378
effigies merged 1 commit intonipreps:masterfrom
sebnaze:master

Conversation

@sebnaze
Copy link
Copy Markdown
Contributor

@sebnaze sebnaze commented Nov 9, 2018

Changes proposed in this pull request

The indexing of the cortical structure name after the split was taking the first letter of 'LEFT' (L) or 'RIGHT' (R) and then comparing it to 'RIGHT' a few lines below to select the proper hemisphere (which was then always False). This resulted in LEFT and RIGHT cortical hemisphere BOLD time series being identical, it now compares the whole word and the output is consistent.

Documentation that should be reviewed

No need for changes in doc.

@welcome
Copy link
Copy Markdown

welcome bot commented Nov 9, 2018

Thanks for opening this pull request! We have detected this is the first time for you to contribute to fMRIPrep. Please check out our contributing guidelines.
We invite you to list yourself as a fMRIPrep contributor, so if your name is not already mentioned, please modify the .zenodo.json file with your data right above Russ' entry. Example:

{
   "name": "Contributor, New FMRIPrep",
   "affiliation": "Department of fMRI prep'ing, Open Science Made-Up University",
   "orcid": "<your id>"
},
{
   "name": "Poldrack, Russell A.",
   "affiliation": "Department of Psychology, Stanford University",
   "orcid": "0000-0001-6755-0259"
},

Of course, if you want to opt-out this time there is no problem at all with adding your name later. You will be always welcome to add it in the future whenever you feel it should be listed.

Copy link
Copy Markdown
Member

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @mgxd?

@effigies effigies changed the title [FIX] duplicate LEFT/RIGHT hemisphere time series in --cifti-output option [FIX] Correctly populate right-hemisphere time series in CIFTI derivatives Nov 12, 2018
@effigies effigies merged commit f77f617 into nipreps:master Nov 12, 2018
@effigies
Copy link
Copy Markdown
Member

@sebnaze Thanks for the fix. Realizing I forgot to ask if you would like to add yourself to the Authors list in the .zenodo file.

@effigies effigies added this to the 1.2.3 milestone Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants