[FIX] Correctly populate right-hemisphere time series in CIFTI derivatives#1378
Merged
effigies merged 1 commit intonipreps:masterfrom Nov 12, 2018
Merged
[FIX] Correctly populate right-hemisphere time series in CIFTI derivatives#1378effigies merged 1 commit intonipreps:masterfrom
effigies merged 1 commit intonipreps:masterfrom
Conversation
|
Thanks for opening this pull request! We have detected this is the first time for you to contribute to fMRIPrep. Please check out our contributing guidelines. Of course, if you want to opt-out this time there is no problem at all with adding your name later. You will be always welcome to add it in the future whenever you feel it should be listed. |
effigies
approved these changes
Nov 9, 2018
Member
|
@sebnaze Thanks for the fix. Realizing I forgot to ask if you would like to add yourself to the Authors list in the .zenodo file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
The indexing of the cortical structure name after the split was taking the first letter of 'LEFT' (L) or 'RIGHT' (R) and then comparing it to 'RIGHT' a few lines below to select the proper hemisphere (which was then always False). This resulted in LEFT and RIGHT cortical hemisphere BOLD time series being identical, it now compares the whole word and the output is consistent.
Documentation that should be reviewed
No need for changes in doc.