ENH: The unit about building and adding a new EMC method #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arokem
reviewed
Mar 19, 2021
Contributor
arokem
left a comment
arokem
left a comment
There was a problem hiding this comment.
A few small comments and suggestions for now.
docs/dmriprep/hmc.md
Outdated
|
|
||
| **Problem**: although most dMRI practitioners employ FSL for the estimation and correction of head-motion and eddy-current distortions, the FSL toolbox has restrictions of commercial use. By using FSL's eddy implementation, *dMRIPrep* inherits those restrictions. | ||
| Therefore, a fully-open implementation of *dMRIPrep* would require eliminating FSL as a dependency. | ||
| In this case, we will provide our own implementation of an algorithm for head-motion and eddy-current-derived distortions. |
Contributor
There was a problem hiding this comment.
I don't know if I like this framing. Arguably, we want to provide a general, open-source solution that is also best in class. The license issues, though real, seem a bit obscure.
josephmje
reviewed
Mar 19, 2021
|
Deploy preview for nipreps-book ready! Built with commit 20f21fc |
oesteban
force-pushed
the
enh/hmc-unit
branch
2 times, most recently
from
f0bde2e to
3370307
Compare
Co-authored-by: Ariel Rokem <arokem@gmail.com>
Co-authored-by: Michael Joseph <josephmje.22@gmail.com>
Member
Author
|
@josephmje, I've pushed some of your edits to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of dumping the documentation scattered around projects, let's have the conversation about EMC here.
@arokem and @dPys, can you please have a look and suggest changes/point out things that seem wrong or even blatantly wrong?