Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Display errors as summary/details elements #464

Merged
merged 3 commits into from Feb 26, 2020

Conversation

@effigies
Copy link
Collaborator

effigies commented Feb 26, 2020

@pull-assistant

This comment has been minimized.

Copy link

pull-assistant bot commented Feb 26, 2020

Score: 0.69

Best reviewed: commit by commit


Optimal code review plan

     ENH: Display errors as summary/details elements

     ENH: Drop list styling for no errors

     TEST: Update expected HTML doc length

Powered by Pull Assistant. Last update 528e525 ... 3dc605b. Read the comment docs.

@effigies

This comment has been minimized.

Copy link
Collaborator Author

effigies commented Feb 26, 2020

This targets a 1.1.8 release to support an fMRIPrep 20.0.1 release.

@mgxd
mgxd approved these changes Feb 26, 2020
Copy link
Contributor

mgxd left a comment

Looks good

niworkflows/reports/report.tpl Outdated Show resolved Hide resolved
@mgxd mgxd added this to the 1.1.8 milestone Feb 26, 2020
@effigies effigies changed the base branch from master to maint/1.1.x Feb 26, 2020
@effigies effigies merged commit e921564 into nipreps:maint/1.1.x Feb 26, 2020
7 checks passed
7 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_docs Your tests passed on CircleCI!
Details
ci/circleci: get_data Your tests passed on CircleCI!
Details
ci/circleci: test_package Your tests passed on CircleCI!
Details
ci/circleci: test_pytest Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@effigies effigies deleted the effigies:enh/error_details branch Feb 26, 2020
effigies added a commit to poldracklab/fmriprep that referenced this pull request Feb 27, 2020
20.0.1 (February 27, 2020)

Bug-fix release in 20.0.x series.

This release includes fixes for rare images with invalid qform matrices and some minor
improvements in report readability and inclusion of common templates in the Docker image.

  * FIX: Handle qforms with invalid quaternions (nipreps/niworkflows#466)
  * FIX: update niworkflows location (#2005)
  * ENH: Display errors as summary/details elements in reports (nipreps/niworkflows#464)
  * DOC: Add ``--fs-subjects-dir`` usage to slurm example (#2003)
  * CI: Test that Docker image can run a common set of output spaces without network access (#1997)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.