Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add option to change data dtype #492

Merged
merged 3 commits into from Apr 3, 2020
Merged

Conversation

mgxd
Copy link
Contributor

@mgxd mgxd commented Apr 1, 2020

Adds data_dtype option to DerivativesDataSink to allow coercing data into desired dtypes.

Inspired by nipreps/fmriprep#2001

@pull-assistant
Copy link

@pull-assistant pull-assistant bot commented Apr 1, 2020

Score: 0.95

Best reviewed: commit by commit


Optimal code review plan

     ENH: Add option to change data dtype

     Merge branch 'master' of github.com:nipreps/niworkflows into enh/deriv...

     ENH: set defaults for common suffixes

Powered by Pull Assistant. Last update 0dcec02 ... f57e2a1. Read the comment docs.

@codecov
Copy link

@codecov codecov bot commented Apr 1, 2020

Codecov Report

Merging #492 into master will increase coverage by 0.12%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #492      +/-   ##
==========================================
+ Coverage   62.66%   62.78%   +0.12%     
==========================================
  Files          42       42              
  Lines        5046     5057      +11     
  Branches      732      732              
==========================================
+ Hits         3162     3175      +13     
+ Misses       1732     1728       -4     
- Partials      152      154       +2     
Flag Coverage Δ
#documentation 33.88% <16.66%> (-0.01%) ⬇️
#masks ?
#reportlettests 100.00% <ø> (ø)
#travis 57.68% <93.33%> (+0.08%) ⬆️
#unittests 45.93% <93.33%> (+0.12%) ⬆️
Impacted Files Coverage Δ
niworkflows/interfaces/bids.py 90.26% <93.33%> (-0.22%) ⬇️
niworkflows/interfaces/images.py 55.82% <0.00%> (+0.14%) ⬆️
niworkflows/viz/utils.py 80.06% <0.00%> (+0.24%) ⬆️
niworkflows/interfaces/mni.py 42.52% <0.00%> (+0.24%) ⬆️
niworkflows/utils/bids.py 77.17% <0.00%> (+0.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e41877...f57e2a1. Read the comment docs.

niworkflows/interfaces/bids.py Outdated Show resolved Hide resolved
niworkflows/interfaces/bids.py Outdated Show resolved Hide resolved
niworkflows/interfaces/bids.py Outdated Show resolved Hide resolved
@mgxd mgxd merged commit 49343a0 into nipreps:master Apr 3, 2020
8 checks passed
@mgxd mgxd deleted the enh/derivative-dtype branch Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants