New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data.get_data() should be consistent across datasets #10

Closed
matthew-brett opened this Issue Jun 17, 2011 · 4 comments

Comments

Projects
None yet
4 participants
@matthew-brett
Copy link
Member

matthew-brett commented Jun 17, 2011

dipy.data.get_data('small_64') returns npy files for the gradients and bvalues, but dipy.data.get_data('small_101D') returns text files, so they need to be loaded using different commands (np.load compared to np.loadtxt). For consistency they should be the same, or (preferably) return data, rather than filenames.

@theaverageguy

This comment has been minimized.

Copy link
Contributor

theaverageguy commented Mar 22, 2016

Is this one still active @arokem ?

@arokem

This comment has been minimized.

Copy link
Member

arokem commented Mar 22, 2016

I believe so.

@theaverageguy

This comment has been minimized.

Copy link
Contributor

theaverageguy commented Mar 22, 2016

Shall I work on the return types of both functions to fix this ? What would be the best way?

MarcCote pushed a commit that referenced this issue Mar 30, 2017

arokem pushed a commit that referenced this issue Apr 22, 2017

Merge pull request #10 from matthew-brett/remove-stdlib-externs
RF: finish removing extern stdlib imports

@skoudoro skoudoro self-assigned this Sep 15, 2018

ShreyasFadnavis pushed a commit to ShreyasFadnavis/dipy that referenced this issue Sep 20, 2018

ShreyasFadnavis pushed a commit to ShreyasFadnavis/dipy that referenced this issue Sep 20, 2018

Merge pull request nipy#10 from matthew-brett/remove-stdlib-externs
RF: finish removing extern stdlib imports
@skoudoro

This comment has been minimized.

Copy link
Member

skoudoro commented Nov 28, 2018

fix by #1283, closing

@skoudoro skoudoro closed this Nov 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment