New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use absolute import in segment, testing and tests #1000

Closed
sahmed95 opened this Issue Mar 22, 2016 · 2 comments

Comments

Projects
None yet
3 participants
@sahmed95
Contributor

sahmed95 commented Mar 22, 2016

Please refer to the original issue #969. Use absolute import in place of relative for all .py files inside /dipy. Take care not to change .pyx or init files

/dipy/dipy/segment/mask.py:
   11      from skimage.filter import threshold_otsu as otsu
   12  except:
   13:     from .threshold import otsu
   14  
   15  from scipy.ndimage import binary_dilation, generate_binary_structure

/dipy/dipy/testing/tests/test_decorators.py:
   11  
   12  
   13: from ..decorators import doctest_skip_parser
   14  
   15  

/dipy/dipy/tests/scriptrunner.py:
    4  something like this in a test module::
    5  
    6:     from .scriptrunner import ScriptRunner
    7      runner = ScriptRunner()
    8  

/dipy/dipy/tests/test_scripts.py:
   28      no_mpl = True
   29  
   30: from .scriptrunner import ScriptRunner
   31  
   32  runner = ScriptRunner(
@souravsingh

This comment has been minimized.

Contributor

souravsingh commented Mar 22, 2016

Part for testing and tests is done in #993. I will work on segment further.

@skoudoro

This comment has been minimized.

Member

skoudoro commented Jun 13, 2017

seems to be ok. Closing !

@skoudoro skoudoro closed this Jun 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment